Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
ef6e6e6 to
3576202
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
3576202 to
d0b291c
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
d0b291c to
d480f32
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
…ocale Should make test colors pass. cmp now also treats an empty LC_ALL or LANG as unset.
d480f32 to
e6a8748
Compare
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
5 open issues
Theget_modification_timedoc comment is now incomplete/misleading after adding the `style:… · New This assertion can be flaky on platforms/filesystems with coarse time resolution (it may return the… · New These tests hardcode locales likeen_US.UTF-8/fr_FR.UTF-8. If locale validation ever becomes… · New These tests hardcode locales likeen_US.UTF-8/fr_FR.UTF-8. If locale validation ever becomes… · New Correct spelling: 'varitations' → 'variations'. · New
Review effort: Lite
| /// Retrieves the modification time of the input file specified by file path | ||
| /// If an error occurs, it returns the current system time |
| let m_time: DateTime<Local> = get_modification_time(invalid_file, TimestampStyle::Iso) | ||
| .parse() | ||
| .unwrap(); | ||
|
|
||
| assert!(m_time > current_time); |
| for (variables, timestamp) in [ | ||
| (&[("LC_ALL", "C")][..], traditional), | ||
| ( | ||
| &[("LC_ALL", "POSIX"), ("LC_TIME", "en_US.UTF-8")], |
| &[("LC_ALL", ""), ("LC_TIME", ""), ("LANG", "POSIX")], | ||
| traditional, | ||
| ), | ||
| (&[("LANG", "fr_FR.UTF-8")], iso), |
| @@ -1,5 +1,5 @@ | |||
| // asserts equality of the actual diff and expected diff | |||
| // considering datetime varitations | |||
| // considering datetime varitations (ISO and traditional formats) | |||
|
GNU diffutils testsuite comparison: |


Stack created with GitHub Stacks CLI • Give Feedback 💬